PR #599 — validate-patch

PR: #599

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region (#599)
Upstream: https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	✅	FROMLIST: prefix correctly prepended; base subject arm64: dts: qcom: hamoa: add audio PD remote heap region matches lore message-ID slug hamoaaudio
Body preserves rationale	✅	Two-sentence body describes reserved memory region for audio PD dynamic loading and VMID list for memory ownership transfers — concise but complete
Fixes tag present/correct	N/A	Feature addition, not a bug fix; no Fixes: tag expected
Authorship preserved	✅	FROMLIST: rule: From: and Signed-off-by: are both Jianping Li <jianping.li@oss.qualcomm.com> — author is the submitter, which is valid; lore author's Signed-off-by: is present
Backport note (if applicable)	N/A	Not a backport
Co-developed-by misuse	✅	No Co-developed-by: present

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/hamoa.dtsi hunk 1 (include)	✅	Adds #include <dt-bindings/firmware/qcom,scm.h> — correct placement in alphabetical include block
arch/arm64/boot/dts/qcom/hamoa.dtsi hunk 2 (fastrpc node)	⚠️	Mixed indentation: memory-region line uses 20 spaces instead of tabs; QCOM_SCM_VMID_ADSP_HEAP continuation uses 34 spaces instead of tabs; surrounding context uses 5 tabs — confirmed by checkpatch (2 ERRORs: code indent should use tabs where possible, 2 WARNINGs: please, no spaces at the start of a line)

Upstream Patch Status

Commit	Community Verdict
arm64: dts: qcom: hamoa: add audio PD remote heap region	⏳ Decision Pending (unknown) — could not fetch lore thread or git trees; network access restricted in this environment; patch posted 2026-04-18, PR submitted 2026-05-19 (~31 days); verify manually at the lore link

qcom-next Presence

Commit	Status
arm64: dts: qcom: hamoa: add audio PD remote heap region	⏭️ Skipped — could not clone/fetch qcom-next; network access restricted; verify manually

Issues

1. Mixed indentation in hunk 2 — memory-region property line uses 20 spaces for indentation instead of tabs, and the QCOM_SCM_VMID_ADSP_HEAP continuation line uses 34 spaces instead of tabs. All surrounding DTS context lines use 5 tabs (\t\t\t\t\t). This is inconsistent with the file's tab-based indentation style and was flagged by checkpatch as 2 ERRORs + 2 WARNINGs.

   Offending lines in the diff:

   +                    memory-region = <&adsp_rpc_remote_heap_mem>;   ← 20 spaces, should be \t\t\t\t\t
   +					qcom,vmids = <QCOM_SCM_VMID_LPASS               ← correct (5 tabs)
   +                                  QCOM_SCM_VMID_ADSP_HEAP>;        ← 34 spaces, should be tab-aligned
   

   Fix: replace leading spaces with tabs to match the surrounding DTS indentation:

   +					memory-region = <&adsp_rpc_remote_heap_mem>;
   +					qcom,vmids = <QCOM_SCM_VMID_LPASS
   +							      QCOM_SCM_VMID_ADSP_HEAP>;
   

2. Lore fetch not possible — b4 is not installed and network access is restricted; the diff could not be compared against the canonical lore patch. The content appears internally consistent and the lore link is well-formed, but a direct diff comparison against the upstream posting was not performed. Recommend re-running validation in a network-enabled environment to confirm diff fidelity.

Verdict

Request changes: fix the mixed-indentation defect in hunk 2 (replace spaces with tabs on the memory-region and QCOM_SCM_VMID_ADSP_HEAP lines) before merging; the commit message and authorship are correct for a FROMLIST: commit.

PR #599 — checker-log-analyzer

PR: #599
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26088610604

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region (#599)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26088610604
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker	Result	Summary
checkpatch	❌	2 errors, 2 warnings — spaces instead of tabs in hamoa.dtsi
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	✅	Log Summary: Test passed (no new DTB errors introduced)
sparse-check	⏭️	Skipping sparse check as nothing changed (no C/H files)
check-uapi-headers	⏭️	Skipping uapi check as nothing changed
check-patch-compliance	❌	Content mismatch + author mismatch for the single commit
tag-check	✅	Commit subject starts with FROMLIST: — valid prefix
qcom-next-check	N/A	Branch is qcom-6.18.y, not qcom-next

---

❌ checkpatch

Root cause: Two lines added to arch/arm64/boot/dts/qcom/hamoa.dtsi use spaces for indentation instead of tabs, violating the kernel DTS coding style.

Failure details:

ERROR: code indent should use tabs where possible
#33: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:4328:
+                    memory-region = <&adsp_rpc_remote_heap_mem>;$

WARNING: please, no spaces at the start of a line
#33: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:4328:
+                    memory-region = <&adsp_rpc_remote_heap_mem>;$

ERROR: code indent should use tabs where possible
#35: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:4330:
+                                  QCOM_SCM_VMID_ADSP_HEAP>;$

WARNING: please, no spaces at the start of a line
#35: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:4330:
+                                  QCOM_SCM_VMID_ADSP_HEAP>;$

d064b21e41785dd76a301401fc72b5a31af6b912 total: 2 errors, 2 warnings, 0 checks, 16 lines checked
Commit d064b21e4178 ("FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region") has style problems, please review.

Fix: Replace the leading spaces on lines 4328 and 4330 of arch/arm64/boot/dts/qcom/hamoa.dtsi with tabs. Looking at the patch, the two offending lines are:

• memory-region = <&adsp_rpc_remote_heap_mem>; — indented with spaces instead of a tab
• QCOM_SCM_VMID_ADSP_HEAP>; — continuation of qcom,vmids value, also space-indented

The corrected hunk should use tabs consistently with the surrounding DTS context:

-                    memory-region = <&adsp_rpc_remote_heap_mem>;
-					qcom,vmids = <QCOM_SCM_VMID_LPASS
-                                  QCOM_SCM_VMID_ADSP_HEAP>;
+					memory-region = <&adsp_rpc_remote_heap_mem>;
+					qcom,vmids = <QCOM_SCM_VMID_LPASS
+							      QCOM_SCM_VMID_ADSP_HEAP>;

Then amend the commit:

git rebase -i <base_sha>   # mark commit d064b21e as 'edit'
# fix hamoa.dtsi indentation
git add arch/arm64/boot/dts/qcom/hamoa.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 6525e228958261ca886962e6c5beaf7787d62ea4..f31a5722521d07f6d3e7c460e56f56008c4a083b

---

❌ check-patch-compliance

Root cause: The commit in the PR differs from the upstream patch referenced by the Link: tag, and the commit author does not match the original patch author on lore.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
  Commit author : Jianping Li <jianping.li@oss.qualcomm.com>

The Link: tag points to:
https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/

Analysis:

1. Content mismatch — the diff in the PR commit differs from the mbox at the lore link. This is likely because the PR commit has the indentation bug (spaces instead of tabs) while the upstream patch uses correct tab indentation, causing a line-level diff between the two.
2. Author mismatch — the upstream patch was authored by Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> but the PR commit is attributed to Jianping Li <jianping.li@oss.qualcomm.com>. The commit author must match the original patch author; if Jianping Li submitted it on behalf of Ekansh Gupta, the author field must be set to the original author and a Signed-off-by: from the submitter added.

Fix:

Step 1 — Fix the author to match the upstream original:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend --author="Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>"
# Ensure Jianping Li's sign-off is present in the commit body if they are the submitter
git rebase --continue

Step 2 — Fix the content to match the upstream patch (also resolves the checkpatch indentation errors):

# Fetch the upstream patch to compare
b4 am --single-message -C -l -3 \
  https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/ \
  -o /tmp/upstream-patch
# Inspect and align the diff with the upstream version

Step 3 — After fixing both author and content, the check-patch-compliance checker should pass.

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src <kernel_src> \
  --base 6525e228958261ca886962e6c5beaf7787d62ea4 \
  --head <head_sha>

---

Verdict

2 blockers to fix before merge:

1. checkpatch (2 ERRORs): Replace space indentation with tabs on lines 4328 and 4330 of arch/arm64/boot/dts/qcom/hamoa.dtsi.
2. check-patch-compliance (2 sub-failures): Fix the commit author to Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> and align the patch content with the upstream lore version (fixing the indentation will likely resolve the content mismatch simultaneously).

Both issues are in the single commit d064b21e and can be resolved in one git commit --amend that corrects the indentation and sets the correct author.